search

fregante / iphone-inline-video

📱 Make videos playable inline on the iPhone (prevents automatic fullscreen)
https://npm.im/iphone-inline-video
MIT License
2.06k stars 298 forks source link

Failed to set currentTime #15

Closed positlabs closed 8 years ago

positlabs commented 8 years ago

I'm getting an error while using chrome's devtools in device mode.

Super minor bug, but makes testing in general slightly more difficult.

screen shot 2016-04-11 at 3 34 09 pm

fregante commented 8 years ago

Make sure that you're setting a number, like 3.4, not "3.4s" nor NaN

positlabs commented 8 years ago

I'm not setting this value anywhere in my code.

This is the only line that references the video.

makeVideoPlayableInline($('.vid')[0], false);
fregante commented 8 years ago

Ah I see what you mean now. I think you can't use Chrome's Dev tools to test it because of how they handle a few things differently from Safari. You might just have to use Safari Remote Debug

fregante commented 8 years ago

Can you verify that the video is being loaded correctly? I saw that issue when the video failed to load and therefore video.currentTime is NaN