iOS 10 detection doesn't work in Captive Network Assistant

fregante / iphone-inline-video

📱 Make videos playable inline on the iPhone (prevents automatic fullscreen)

https://npm.im/iphone-inline-video

MIT License

2.06k stars 298 forks source link

iOS 10 detection doesn't work in Captive Network Assistant #78

Closed shaketbaby closed 7 years ago

shaketbaby commented 7 years ago

matchMedia('(-webkit-video-playable-inline)').matches return false in Captive Network Assistant.

fregante commented 7 years ago

Do the videos play inline natively in there?

If yes, this only means that IIV is enabled more often than it should, which is preferrable to not enabled when it should

If not, it's an Apple bug. In that case, does IIV work?

shaketbaby commented 7 years ago

Video doesn't seem to play inline in CNA, but there's a button now to allow user to put video inline. IIV does seem to work.

fregante commented 7 years ago

From what I understand:

playsinline doesn't work natively, so matchMedia('(-webkit-video-playable-inline)').matches rightfully returns false
IIV is thus enabled and adds the ability to play videos inline.

I'm not sure of where the bug is :D

shaketbaby commented 7 years ago

The bug is the check for iOS 10 doesn't work in CNA, which turns out to be a good thing. Just thought you might be interested in knowing this, anyway.

fregante commented 7 years ago

Ah thank you! I was confused on whether it was a bug report =)

Technically that media query specifically detects support for native inlive video playback, so it's working as expected.

Fun fact: the query has been there since iOS 8 but was broken in iOS 9. Also barely anyone ever knew about it for the past two years :(