search

fregante / notifications-preview-github

Browser Extension: preview GitHub notifications with same page pop-overs
https://chrome.google.com/webstore/detail/github-notifications-prev/kgilejfahkjidpaclkepbdoeioeohfmj?hl=en&gl=IN
MIT License
142 stars 15 forks source link

Store publish not working? #131

Closed tanmayrajani closed 1 month ago

tanmayrajani commented 2 years ago

I published a release yesterday with a fix for #130 but it doesn't seem to have reached chrome/firefox stores. Not sure what's wrong..

cc @fregante if you have any idea, could you please look into?

fregante commented 2 years ago

Releases are done via the actions tab, not by creating releases manually. The release and tag should be deleted and then done via the Release action.

tanmayrajani commented 2 years ago

thanks @fregante, I forgot 🤦‍♂️

also, getting "{\n \"error\": \"invalid_grant\",\n \"error_description\": \"Bad Request\"\n}" in chrome, whereas firefox succeeded after first error (needed to accept ToC)

tanmayrajani commented 2 years ago

however, chrome upload succeeded despite getting that error :)

tanmayrajani commented 2 years ago

it shows updated ~version~ date in chrome developer dashboard.. but on the webstore, it's still old version 😐

tanmayrajani commented 2 years ago

@fregante should we renew client ID, secret etc as mentioned in https://github.com/fregante/chrome-webstore-upload-cli/issues/36 for the time being?

fregante commented 2 years ago

Both stores may require you to update some details on the developer dashboard. Make sure there's a privacy policy on Google's dashboard and a verified email.

As for the key, it's up to you. Just remember to update the workflow too because it's using an older version of the uploader.

fregante commented 2 years ago

But that's strange, invalid grant means that the token is wrong, so yes, it's probably best to follow the guide again.

fregante commented 2 years ago

Once you follow the guide to update the Chrome token, please release a new version via the Actions tab as described. It'd be great to merge https://github.com/tanmayrajani/notifications-preview-github/pull/125 before then as well.

tanmayrajani commented 2 years ago

@fregante sure, I'll take a look at this soonish

Also, Firefox asked for source-code upload (you might be getting emails too I guess). I provided it manually.. but I was wondering whether this is something that can be done via github action too

fregante commented 2 years ago

you might be getting emails too I guess

Yes, AMO is really annoying.

I was wondering whether this is something that can be done via github action too

Blocked by:

Technically there's an API endpoint now but no libraries for it

fregante commented 1 month ago

Ping @tanmayrajani could you generate new keys with the guide at:

https://github.com/fregante/chrome-webstore-upload-keys#how-to-generate-google-api-keys