fregante / notifications-preview-github

Browser Extension: preview GitHub notifications with same page pop-overs
https://chrome.google.com/webstore/detail/github-notifications-prev/kgilejfahkjidpaclkepbdoeioeohfmj?hl=en&gl=IN
MIT License
144 stars 15 forks source link

Make Mark All As Read optional #155

Closed karlhorky closed 2 months ago

karlhorky commented 2 months ago

I just noticed the new "Mark all as read" link that was added in this PR by @tjx666:

It seems like a nice feature! Maybe even good enough to be default for most users 👍

But for me (and maybe also others), it makes me nervous that I will accidentally click on it and mark everything as read. I often keep notifications as a kind of ad-hoc todo list for myself.

Also, it takes up extra vertical space, which I would like to avoid:

Screenshot 2024-08-17 at 18 02 14

So I added an option (default: link enabled), which allows users to disable the link if they like.

cc @fregante what do you think?

karlhorky commented 2 months ago

Apart from the approval by @tjx666, anything else I can do in this PR to make it ready?

tjx666 commented 2 months ago

fine.

karlhorky commented 2 months ago

Thanks for the review, merge and publish of notifications-preview-github@24.8.19 🙌