search

fregante / notifications-preview-github

Browser Extension: preview GitHub notifications with same page pop-overs
https://chrome.google.com/webstore/detail/github-notifications-prev/kgilejfahkjidpaclkepbdoeioeohfmj?hl=en&gl=IN
MIT License
144 stars 15 forks source link

Restore "Mark as read" #94

Closed fregante closed 4 years ago

fregante commented 4 years ago

The feature was dropped in https://github.com/tanmayrajani/notifications-preview-github/commit/606d0227ad7d7693456af39d9ddc6fdd608ed4ad#diff-ee206f3e88c066917fc8b643bf8fa7a6 because it's incompatible with the new Notifications style and the button itself needs better CSS.

Help wanted to restore this feature.

Moved from https://github.com/tanmayrajani/notifications-preview-github/issues/93

silverwind commented 4 years ago

Should add both the "Done" and "Unsubscribe" buttons present on the notifications page.

fregante commented 4 years ago

It appears that if we load the missing script on the page, this will start working without extra JS code.

Missing script: https://github.githubassets.com/assets/notifications-v2-bootstrap-9ab1c3e0.js

We can get this URL from the notifications page and inject it only once the user opens the dropdown.

The second part of this issue would be to restore the buttons via CSS and fix their position/size/spacing (smaller and more compact)

mallowigi commented 4 years ago

I've opened a PR, please take a look.

tanmayrajani commented 4 years ago

This got implemented in #98. Closing.