Closed mallowigi closed 4 years ago
Thank you! We can merge this, but can you undo all the unrelated changes? Like the indentation and the changes to manifest.json
I must admit that I didn't test Firefox. Can you do it ?
(Firefox) I don't see the buttons, but I see this, which isn't great:
Can you post a screenshot of what it looks like for you?
I never developed extensions for Firefox, but I'll check anyways.
By the way, this is how it looks in Chrome:
I'm using the existing behavior of the on hover buttons, I think it's a minor inconvevenience. The problem is that normally the actions are overlapping the timestamp column in the notification, but in the plugin this column is hidden in compact.
If you want to improve it, please do, but what interests me is the functionality, not the UI. And in that terms I'm okay with my fix.
I've improved the UI, now I've added ellipsis to the link on hover, so that the buttons don't overlap the text
I've found out that I added the styles from github dark by mistake. I fixed that, but then it means that I'll need to add the styles to the github dark repo as well.
So are you merging ?
anyone home ?
Thank you so much, @mallowigi! This is great! Sorry for the delay in merging :)
I noticed a minor improvement with the save/unsave, I'll get that done soon.
Hi, I've restored the mark as read functionality. I am working with this extension a lot and it annoyed me that such a feature wasn't available so I made my own fork.
I'm not sure what your plans are, you're free to fork from my fork and add your own fixes.
In the meantime I will be using this fork in my everyday.
Thanks!