search

fregante / webext-permission-toggle

Browser-action context menu to request permission for the current tab.
https://fregante.github.io/webext-permission-toggle/
MIT License
70 stars 5 forks source link

Add support for Manifest v3 #28

Closed aspiers closed 9 months ago

aspiers commented 9 months ago

This is only lightly tested on Chrome with a v3 manifest, not with any v2 manifests or other browsers such as Firefox.

fregante commented 9 months ago

@aspiers how does it look? I published a beta version as v4.1.0-0 that you can install directly.

One thing I'd avoid in this PR is to update the dependencies (except maybe @types/chrome if necessary). This way I can release it as a minor version for now

aspiers commented 9 months ago

@aspiers how does it look? I published a beta version as v4.1.0-0 that you can install directly.

Will test and let you know!

One thing I'd avoid in this PR is to update the dependencies (except maybe @types/chrome if necessary). This way I can release it as a minor version for now

Ah sorry, I thought you'd asked for that, but looking back at that comment I see you probably meant something else.

fregante commented 9 months ago

Oh yeah I did ask for it, thinking that those dependencies were recently updated to improve MV3 compat, but that isn't the case.

The dev dependencies also change the output so I'll skip them for now

aspiers commented 9 months ago

Still testing this and trying to untangle various issues as mentioned in https://github.com/fregante/webext-domain-permission-toggle/issues/29#issuecomment-1897594305

fregante commented 9 months ago

This works for me. The other issues I see are unrelated to MV3