search

fregante / webext-permission-toggle

Browser-action context menu to request permission for the current tab.
https://fregante.github.io/webext-permission-toggle/
MIT License
70 stars 5 forks source link

demo/readme.md has inaccuracies #41

Closed aspiers closed 4 months ago

aspiers commented 9 months ago

For example, npm run watch doesn't work. I only see demo:build and demo:watch in the parent package.json, but no scripts at all defined in demo/package.json.

fregante commented 9 months ago

That package.json is just for Parcel. The commands exist and work at the top level

fregante commented 9 months ago

However I see that manual-test doesn't exist, it was renamed

aspiers commented 9 months ago

The commands exist and work at the top level

Yeah but it's normal to expect to be able to run commands from within the directory containing the readme.md. If they need to be run from the top-level then it would definitely be worth mentioning that explicitly.

However I see that manual-test doesn't exist, it was renamed

Right, also there's a missing line after the cd.