fregante / webext-permission-toggle

Browser-action context menu to request permission for the current tab.
https://fregante.github.io/webext-permission-toggle/
MIT License
70 stars 5 forks source link

Show correct status when manifest permission has been removed #54

Closed fregante closed 3 months ago

fregante commented 3 months ago

cc @aspiers

Default (unchanged)

Manifest granted access to the GitHub.com domain; the toggle is disabled

Screenshot 13

Manifest permission removed (old behavior)

The toggle was checked and disabled even when the user removed access to the extension.

Screenshot 15

Manifest permission removed (this PR)

The toggle is unchecked and enabled if the user removed access. This reflects reality and gives the user an easy way to restore the permission.

Screenshot 14

Known bugs

fregante commented 3 months ago

I really wish the browser would enable their own toggle so we didn't have to use this package at all. The UI is there, but disabled. 😒 "x.com" should be clickable, but isn't.

Screenshot 16
aspiers commented 3 months ago

Nice work, thanks!