search

frehner / modern-guide-to-packaging-js-library

A guide to help ensure your JavaScript library is the most compatible, fast, and efficient library you can make.
GNU General Public License v3.0
1.44k stars 38 forks source link

Chinese translation #13

Closed SyMind closed 2 years ago

SyMind commented 2 years ago

I'm enjoy reading this tutorial. Thank you for your effort! @frehner

frehner commented 2 years ago

The other PR was merged, so you may need to update some content here.

SyMind commented 2 years ago

ok

获取 Outlook for iOShttps://aka.ms/o0ukef

发件人: Anthony Frehner @.> 发送时间: Friday, September 2, 2022 6:48:29 AM 收件人: frehner/modern-guide-to-packaging-js-library @.> 抄送: Cong-Cong Pan @.>; Author @.> 主题: Re: [frehner/modern-guide-to-packaging-js-library] Chinese translation (PR #13)

The other PR was merged, so you may need to update some content here.

― Reply to this email directly, view it on GitHubhttps://github.com/frehner/modern-guide-to-packaging-js-library/pull/13#issuecomment-1234863795, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEXOYBMV53MVXORDCTVYOHLV4EXD3ANCNFSM6AAAAAAQCOP4KM. You are receiving this because you authored the thread.Message ID: @.***>

SyMind commented 2 years ago

@frehner I've already revised it and translated the updated content.

SyMind commented 2 years ago

Forgive me if what you have is correct, but I was wondering if there is an inconsistency with the commas used. For example, the comma after React and then the commas after the second section (in the screenshot below)

Is that intentional / something that is correct? Are they both valid, or should one be used over the other?

Screen Shot 2022-09-02 at 2 29 38 PM

In Chinese, people prefer to use "、" to separate several nouns rather than comma.

frehner commented 2 years ago

In Chinese, people prefer to use "、" to separate several nouns rather than comma.

Thanks for explaining that! 👍