Closed Noki closed 3 weeks ago
we can still just have this check and it will fail for not, but not affect the ability to still merge.
I like this approach in general, as this check feels more optional.
I think this is PR is ready to be merged now. The checks fails unless mac_overrides are properly set for all devices with a require flag, however since this is not a required check a PR failing this check can still be merged.
Looks good, very useful to include the command for each device :+1:
I tried to make this run only on changed files, however I could not get this to work with github actions, it only worked locally for me.
The following issues exist and should be fixed at some point, however I think we can still just have this check and it will fail for not, but not affect the ability to still merge.