freifunk-berlin / bbb-configs

Ansible based configuration management openwrt mesh nodes in the city-wide backbone of Freifunk Berlin
GNU Affero General Public License v3.0
14 stars 24 forks source link

workflows: check for missing mac_overrides #941

Closed Noki closed 3 weeks ago

Noki commented 1 month ago

I tried to make this run only on changed files, however I could not get this to work with github actions, it only worked locally for me.

The following issues exist and should be fixed at some point, however I think we can still just have this check and it will fail for not, but not affect the ability to still merge.

FFHener commented 1 month ago

we can still just have this check and it will fail for not, but not affect the ability to still merge.

I like this approach in general, as this check feels more optional.

Noki commented 1 month ago

I think this is PR is ready to be merged now. The checks fails unless mac_overrides are properly set for all devices with a require flag, however since this is not a required check a PR failing this check can still be merged.

pktpls commented 3 weeks ago

Looks good, very useful to include the command for each device :+1: