search

freifunk-berlin / falter-builter

build falter images using precompiled openwrt imagebuilders.
6 stars 6 forks source link

Error reporting #116

Closed pktpls closed 1 year ago

pktpls commented 2 years ago

It took me a while to notice that weird things are happening because I didn't have patch installed :-) Would be really good to have some sort of error reporting, otherwise I have to 1) notice something is wrong in the first place, and 2) scan the long output for error messages.

I understand set -e is disabled because we do want to ignore some errors from the imagebuilder. Maybe a useful compromise would be to disable set -e only for the imagebuilder call?

Akira25 commented 2 years ago

I understand set -e is disabled because we do want to ignore some errors from the imagebuilder. Maybe a useful compromise would be to disable set -e only for the imagebuilder call?

That sounds like a reasonable solution to me. Aditionally, we should include patch into the dependency-check code.