Closed pmelange closed 3 years ago
pmelange
commented
3 years ago https://github.com/Freifunk-Spalter/packages/pull/154 https://github.com/Freifunk-Spalter/packages/pull/155 have been merged. Now all production branches are ready to support the above mentioned changes
Akira25
commented
3 years ago This way, things like -p packageset could be just "tunneldigger" and -v version would no longer be needed.
I don't get why we can drop the version and the packageset options.
As far as I would implement this now, the -p option must remain, to determine the image-flavor. If we set it to all it will build all three flavors (which is the behavior already).
The option -v would not determine the openwrt version. It would tell the falter version, which maps directly to the versions in the feeds directory: http://firmware.berlin.freifunk.net/feed/ (1.1.0, 1.1.1-snapshot and so on)
Akira25
commented
3 years ago A draft for this is in feature/reduce_cmd-options branch
Akira25
commented
3 years ago @pmelange feel free to repoen this issue, if the PR didn't match your expactations, please.
similar to https://github.com/Freifunk-Spalter/repo_builder/issues/7
There are currently a few PR's in the packages repo which are designed to help steer how the feeds and images are built. In the package "falter-common" the file ./etc/freifunk_release has the variable FREIFUNK_OPENWRT_BASE which can (as of this point in time) the following values:
These refer directly to the directories on downloads.openwrt.org. In all cases except "master", the files will be found in the "releases" directory. For master, the files will be found in the "snapshots" directoy.
This way, things like -p packageset could be just "tunneldigger" and -v version would no longer be needed.
The following bit of code would probably be better placed somewhere more global in the script. https://github.com/Freifunk-Spalter/builter/blob/2f713292f3ed2f667b41bf8a4b65d6a3708321ac/build_falter#L268-L271