search

freifunk-berlin / falter-repo_builder

DEPRECATED: Build a package feed with dockerized OpenWrt-SDK
3 stars 3 forks source link

build_feed: drop -i flag #4

Closed Akira25 closed 3 years ago

Akira25 commented 3 years ago

docker refuses to run in a buildbot-worker-session due to the -i flag. As we do not pipe anything into the docker-command, we can safely drop it.

PolynomialDivision commented 3 years ago

https://github.com/Freifunk-Spalter/repo_builder/pull/2

pmelange commented 3 years ago

@PolynomialDivision wants to get rid of the - t option and you want to get rid of the -i option. Will that work?

PolynomialDivision commented 3 years ago

@PolynomialDivision wants to get rid of the - t option and you want to get rid of the -i option. Will that work?

No idea. xD

Akira25 commented 3 years ago

As far as I can tell, the buildbot should even work without -t. There is nothing we want to pipe into containers via stdin, right?

-t, --tty=true|false
          Allocate a pseudo-TTY. The default is false.

       When  set to true Docker can allocate a pseudo-tty and attach to the standard input of any container. This can be used, for example,
       to run a throwaway interactive shell. The default is false.

       The -t option is incompatible with a redirection of the docker client standard input.
PolynomialDivision commented 3 years ago

Can we close and accept mine? I now removed it

Akira25 commented 3 years ago

right. :)