search

freifunk-berlin / firmware

DEPRECATED: Build system for Berlin firmware. Please user the pinned falter-repos instead
https://berlin.freifunk.net
GNU General Public License v3.0
74 stars 34 forks source link

"Status" page link in public router UI not working #243

Open basros opened 9 years ago

basros commented 9 years ago

Version: 0.1.0 - 0.1.1-alpha

Some links in the upper main menu are broken: Depending on which menu-entry has been selected, some other menu-entries will link to previous-entry + anker. Map + Services seem to OK. I did not manage to get to the status page at all!

booo commented 9 years ago

I guess this is related to https://github.com/freifunk-berlin/firmware/issues/197

sarumpaet commented 9 years ago

It took me a bit to figure out what basros actually meant. I guess the expected behaviour is to get to some Status page when clicking on the "Status" menu entry in the public router UI. I wasn't even aware such a page exists (it's at /freifunk/status); I thought the "Status" menu was merely badly named (and should be called "Diagnostics" or something, with the Test Download in it). :)

Seems the menu system doesn't support menu (titles) that both represent a page and a menu title. See the "OLSR" entry - it's merely a headline. So this is a bug in luci-mod-freifunk (upstream). It can be fixed by patching /usr/lib/lua/luci/controller/freifunk/freifunk.lua with an additional

entry({"freifunk", "status", "status"}, template("freifunk/publicstatus"), ("Status"))

line. I wonder why https://github.com/openwrt/luci/blob/master/modules/luci-mod-freifunk/luasrc/controller/freifunk/freifunk.lua doesn't have this. Perhaps there's a LuCI/luci-mod-freifunk version mismatch?

As a side note, I dislike luci-mod-freifunk. It combines a lot of functionality into one package (remote update+public status+public information about possibly private Wifi devices+additional JSON interface+test download). I don't see why a typical mesh router should expose more information than some contact information and further links, if at all.

basros commented 9 years ago

Issue seems to be related to bootstrap:

15:31 < ufo-v4> hab grad mal theme-bootstrap installiert.. ja, da geht "status" auch nicht mehr... mit dem freifunk-theme gehts

Kudos to @FreifunkUFO for testing!

booo commented 9 years ago

@sarumpaet can you fix this upstream?

sarumpaet commented 8 years ago

In openwrt/feeds/luci/themes/luci-theme-bootstrap/luasrc/view/themes/bootstrap/header.htm:

<li class="dropdown">                                             
<a class="menu" href="#">

-- replace "#" by "<%=pcdata(href)%>" See also https://github.com/openwrt/luci/issues/713 - not sure if we have some version mixup there.