owm.lua doesn't work on lede build

freifunk-berlin / firmware

DEPRECATED: Build system for Berlin firmware. Please user the pinned falter-repos instead

https://berlin.freifunk.net

GNU General Public License v3.0

73 stars 34 forks source link

owm.lua doesn't work on lede build #435

Closed bobster-galore closed 7 years ago

bobster-galore commented 7 years ago

Since data structure changed /usr/sbin/owm.lua doesn't work anymore. this affects only Devices with radio built in.

(on cpe210 ) /usr/lib/lua/luci/owm.lua fails with accessing a NIL-value an for this no data for hopglass & openwifimap will be uploaded. When I comment out line 289 - 297 from owm.lua https://github.com/freifunk-berlin/firmware-packages/blob/master/utils/luci-app-owm/luasrc/owm.lua#L289 it will show up again, but of course w/o WiFi-data populated.

SvenRoederer commented 7 years ago

the way of gathering the data seems to be different now. see https://github.com/openwrt/luci/blob/fecf6e1d11d466efa7b1bbf05633931a3081517e/modules/luci-base/luasrc/tools/status.lua#L160

SvenRoederer commented 7 years ago

just made branch "https://github.com/freifunk-berlin/firmware-packages/tree/owm-wifi_hotfix" which disables the broken section. This will be included into all SAm0815* images for now

bobster-galore commented 7 years ago

There was just an issue [1] on Berlin ml, that an CPE210 1.1 EU isn't showing up in the wifimap using the Development Master (293). There is still an issue with owm.lua and I don't have the time to fix it now. I propose that we include above mentioned owm-wifi_hotfix in Development Master. [1] https://lists.berlin.freifunk.net/pipermail/berlin/2017-June/035882.html

SvenRoederer commented 7 years ago

I just created a RP https://github.com/freifunk-berlin/firmware-packages/pull/108 to merge this hotfix (disabling incompatible code) ... Let's discuss on the next community-meeting

booo commented 7 years ago

This affects the current master branch?

bobster-galore commented 6 years ago

Hej folks, on a wr842v3 running "Freifunk Berlin Hedy SAm0815-ffuplink 5799d8d r2993+469-b9a408c" owm.lua does nothing. It doesn't update a doc nor does it give an error message. ru bob

SvenRoederer commented 6 years ago

What is "owm.lua --dry-run" giving as output?

bobster-galore commented 6 years ago

errr, didn't save the original owm.lua when testing different versions, now it's from Kathleen 0.3.0. And working, before I tried --dryrun. :( Can't there be a hint to --dry-run? So the coordinates were missing despite I entered them in the wizard.

booo commented 6 years ago

Please open another ticket for this problem. We definitely can work on this.

bobster-galore commented 6 years ago

How u mean? hint 4 --dry-run or entered coordinates disappear (will check w/ firstboot when time permits.)

booo commented 6 years ago

"Can't there be a hint to --dry-run?"

Maybe I misinterpreted you writing but I thought you requested a bit more output from owm.lua, e.g. a --help argument or a message when the coordinates are missing.

bobster-galore commented 6 years ago

U were right and I opened #485. oh, automatic for the ppl.