missing tcpdump package

freifunk-berlin / firmware

DEPRECATED: Build system for Berlin firmware. Please user the pinned falter-repos instead

https://berlin.freifunk.net

GNU General Public License v3.0

74 stars 34 forks source link

missing tcpdump package #464

Closed booo closed 7 years ago

booo commented 7 years ago

In the default image from Firmware Berlin (Hedy 1.0.0-olsrd0903-alpha rev e0debcd) Generic - ar71xx/generic the tcpdump package is missing. We should check for tcpdump prior to a new release.

Maybe we should write a small script that checks the images for packages?

SvenRoederer commented 7 years ago

tcpdump seems to have been never included in the default image ever.

booo commented 7 years ago

I think we should include tcpdump into the default image of all >4MB boards because it's one of the standard tools for debugging.

SvenRoederer commented 7 years ago

there is no user-request till now
as there seems no real demand, it might just blow up the final images
it can be installed anytime via opkg
it makes it more "inviting" to sniff users data

But feel free, if you really like it included

bobster-galore commented 7 years ago

Since u can easily install tcpdump by opkg install tcpdump, I think we should not bloat standard images. Common users probably don't need that at all.

booo commented 7 years ago

Well they also don't need tmux, iperf, ethtool and other stuff. Tcpdump is one of the standard tools for network debugging. It qualifies for the standard tool set on the router.

I will check how much space is left on 8MB boards and add the package to the default set if there is still enough space for other stuff afterwards.

pmelange commented 7 years ago

tcpdump-mini is also one of the first things I install on a new router. It would be nice if it were there by default.

booo commented 7 years ago

And by the way we can't install stuff if we are not already connected...

booo commented 7 years ago

Situtation with build-in tcpdump:

root@LEDE:~# df -h
Filesystem                Size      Used Available Use% Mounted on
/dev/root                 4.5M      4.5M         0 100% /rom
tmpfs                    61.5M    244.0K     61.3M   0% /tmp
/dev/mtdblock3            2.3M    296.0K      2.0M  13% /overlay
overlayfs:/overlay        2.3M    296.0K      2.0M  13% /
tmpfs                   512.0K         0    512.0K   0% /dev

We could install tcpdump-mini instead. The current backbone image uses tcpdump. Maybe it's a good idea to install the same package?

Anyway I think we have enough space left on 8MB devices to install one version of tcpdump.

SvenRoederer commented 7 years ago

solved by merging PR #468