freifunk-berlin / firmware

DEPRECATED: Build system for Berlin firmware. Please user the pinned falter-repos instead
https://berlin.freifunk.net
GNU General Public License v3.0
73 stars 34 forks source link

Profiles: Remove DNS-Server 213.73.91.35 #551

Closed pmelange closed 5 years ago

pmelange commented 6 years ago

The DNS server 213.73.91.35 is offline. It is set in many of the profiles and needs to be removed.

https://twitter.com/clubdiscordia/status/983109445784875009?s=11

SvenRoederer commented 6 years ago

please create a upstream PR to remove this entry from luci-profiles.

pmelange commented 6 years ago

openwrt/luci#1757

pmelange commented 6 years ago

Pull Request openwrt/luci#1759

pmelange commented 6 years ago

PR: hnyman merged commit https://github.com/openwrt/luci/commit/0c30ee07ce70073df639148b48daa08682f3e1d0 into openwrt:master

booo commented 6 years ago

We should find a replacement for the old one.

The ip is still in the olsrd configuration:

https://github.com/freifunk-berlin/firmware-packages/blob/master/defaults/freifunk-berlin-olsrd-defaults/uci-defaults/freifunk-berlin-olsrd-defaults#L44

pmelange commented 6 years ago

Yes, we should find a new one. A new nameserver should go in its own issue/pr.

The host still responds to pings. There is no problem with it being in the olsrd ping list

booo commented 6 years ago

Is there a issue for a new nameserver? Can you create one if there is no issue?

We should not assume that the host stays online and should remove it from the ping list or better replace it.

pmelange commented 6 years ago

New issue created for a new potential nameserver #552

SvenRoederer commented 6 years ago

just requested a cherry-pick into lede-17.01 branch (https://github.com/openwrt/luci/issues/1760).

we also need a migratioin for the DNS-server list

booo commented 5 years ago

This pull request includes a migration script: https://github.com/freifunk-berlin/firmware-packages/pull/152

SvenRoederer commented 5 years ago

As the removal of the retired DNS-server has been backported to lede-17.01 (https://github.com/openwrt/luci/commit/09ae638e4b4eb6ee11fd718caf209c6c983a6e0e) we need to add a migration for Hedy-1.0.2

new DNS-Servers have been added to lede-17.01 (https://github.com/openwrt/luci/commit/27ff6e930f6b08560639ceebdc9595da311a9e10) which also needs to be migrated

https://github.com/freifunk-berlin/firmware-packages/commit/212db23968edc8bcc5302e9a08a2c51d97490aa0 adds a migration for Hedy-1.0.2

pmelange commented 5 years ago

Maybe this should be run with every migration. A standard thing to do, always set the DNS servers. There might be a couple of other things we could pull from the profiles with every boot.

Here is the code in the master branch

https://github.com/freifunk-berlin/firmware-packages/blob/ea6d78598a3edf4daca5c72208946364b7d1b136/utils/freifunk-berlin-migration/uci-defaults/freifunk-berlin-01-migration.sh#L443-L452

SvenRoederer commented 5 years ago

with https://github.com/freifunk-berlin/firmware-packages/commit/212db23968edc8bcc5302e9a08a2c51d97490aa0 this is fixed for Hedy-1.0.2 so changing the milestone

SvenRoederer commented 5 years ago

master: migration: https://github.com/freifunk-berlin/firmware-packages/commit/a2156221f511e4ee4283323dc4b68103b04010bd; profile: https://github.com/openwrt/luci/commit/c2d3fe8a9730a519278def5534c60ee6991185c3#diff-3faaef5bc5179c8442a73059db372a80 V1.0.2: migration: https://github.com/freifunk-berlin/firmware-packages/commit/212db23968edc8bcc5302e9a08a2c51d97490aa0; profile: https://github.com/openwrt/luci/commit/09ae638e4b4eb6ee11fd718caf209c6c983a6e0e#diff-3faaef5bc5179c8442a73059db372a80