search

freifunk-berlin / firmware

DEPRECATED: Build system for Berlin firmware. Please user the pinned falter-repos instead
https://berlin.freifunk.net
GNU General Public License v3.0
73 stars 34 forks source link

Hedy-1.0.2-dev: uci setting ffberlin-uplink.preset.previous is set multiple times #638

Closed pmelange closed 5 years ago

pmelange commented 5 years ago

This is tested with build b76e14d

When performing multiple change-uplink procedures, the UCI value ffberlin-uplink.preset.previous has multiple entries.

pmelange commented 5 years ago

example:

/etc/config# cat ffberlin-uplink 

config settings 'preset'
    option previous 'no-tunnel'
    option previous 'tunnelberlin_openvpn'
    option current 'tunnelberlin_tunnneldigger'

config settings 'uplink'
    option auth 'none'
pmelange commented 5 years ago

After the next change-uplink to default, the ffberlin-uplink file looks like this

config settings 'preset'
    option previous 'tunnelberlin_openvpn'
    option previous 'tunnelberlin_tunnneldigger'
    option current 'no-tunnel'

config settings 'uplink'
    option auth 'none'
pmelange commented 5 years ago

PR https://github.com/freifunk-berlin/firmware-packages/pull/170 has been created to implement the changes. Feel free to merge at any time.

SvenRoederer commented 5 years ago

merged in https://github.com/freifunk-berlin/firmware-packages/commit/adf37cd41b2dd9c4cb8277502f787c5f6d5e5e26