search

freifunk-berlin / firmware

DEPRECATED: Build system for Berlin firmware. Please user the pinned falter-repos instead
https://berlin.freifunk.net
GNU General Public License v3.0
73 stars 34 forks source link

mac addr for ffuplink changes when change-uplink is performed #639

Open pmelange opened 5 years ago

pmelange commented 5 years ago

This is tested with build b76e14d

When changing, for example, between tunnel-berlin-tunneldigger and default (or visa-versa) the macaddr for ffuplink gets regenerated. It would be better to have this stay between changes. It might be a good idea to keep this value in ffberlin-uplink.

SvenRoederer commented 5 years ago

see https://github.com/freifunk-berlin/firmware-packages/pull/171#issuecomment-446712769

SvenRoederer commented 5 years ago

is it worth blowing up the code just for keeping the mac-address? How often a user will change the uplink-type, which will trigger a regeneration of the MAC-address?

SvenRoederer commented 5 years ago

let's discuss this for hedy-1.1

torte71 commented 5 years ago

Why not deriving the ffuplink MAC-address from the interface, that it runs on (e.g. only set the first byte to 'fe' and take the other bytes from eth0)? No need to save it and it would always be the same, even after reflashing.

pmelange commented 5 years ago

@torte71 It was also my first idea. But after discussions at the freifunk meetings, where we spoke about ways to reduce the amount of data which can be linked back to a device, I thought it would be better to generate something random.

For hedy-1.1 I would like to get this integrated into the change-uplink code. I feel that there are a lot more fine touches we could make to improve the change-uplink system. Especially reducing duplicated code.

SvenRoederer commented 5 years ago

I wonder if it will break anything, if we define a "ffuplink_dev" by default and rely on this. So we have always the same mac-address and need to carry this value in ffberlin-uplink.