search

freifunk-berlin / firmware

DEPRECATED: Build system for Berlin firmware. Please user the pinned falter-repos instead
https://berlin.freifunk.net
GNU General Public License v3.0
73 stars 34 forks source link

dnsmasq stopped working after update in case of numerous dnsmasq options #678

Open Aldrighetti opened 5 years ago

Aldrighetti commented 5 years ago

After upgrade to hedy 1.0.2 dnsmasq stopped working because of numerous options in list dhcp_option '3,10.36.11.1 6,10.36.11.1 10.36.11.2' After upgrade to hedy 1.0.2 from kathleen 0.3.0 dnsmasq stopped working because it requires now one option per line in /etc/config/dhcp list dhcp_option '3,10.36.11.1' list dhcp_option 6,10.36.11.1 10.36.11.2' Would be nice if that can detected.

SvenRoederer commented 5 years ago

@Aldrighetti the shown options have been added by you, right? From the code I can only find :

As the default setup only uses 1 dhcp-option (see 2nd point) this have probably never caused failures before.

pmelange commented 5 years ago

Manually edited changes, which cause problems after upgrading, has also been cited in issue https://github.com/freifunk-berlin/firmware/issues/651.

If the configuration from CC or BB do not work anymore with LEDE (17.x) and higher, then I think it makes sense to check for these things in the migration scripts. Now we know that list dhcp_option no longer works unless split up into multiple entries.

I recommend a generic function in the migration script which will take a list option and break it into multiple lines. This could then be used where needed.

SvenRoederer commented 5 years ago

When this was a manual change, and confirmed by @Aldrighetti, we should:

  1. check why this was made (probably it's a general good idea to implement this)
  2. We should think of how to deal with manual changes which 2.1. interfer with our defaults 2.2. do not interfer with our defaults, but are also not upstream defaults (like in #651)

But as mentioned above, the wizard should be fixed to use a list in place of a plain option.

Aldrighetti commented 5 years ago

@SvenRoederer Yes can confirm it, that was an manual change.