search

freifunk-berlin / hopglass.berlin.freifunk.net

Hopglass node map configuration files and converter for OWM data
0 stars 1 forks source link

owm2ffmap.py: python3 compatibility #7

Closed Akira25 closed 4 years ago

Akira25 commented 4 years ago

This commit will change the method .iteritems (python2 and not supported anymore) to its python3 pendant.

SvenRoederer commented 4 years ago

Have you ran python "2to3" on this code? Is it now all python3 syntax ?

Akira25 commented 4 years ago

I just checked that. It should be valid python3 now, because 2to3 only tries to modify the print-functions further (in a ridiculous way...). Currently I try to test a solution for issue #2 and came up with that wrong method.

Should this maybe include in that commit then?

Akira25 commented 4 years ago

I managed to get the script running under python3 on my system. So i think now should everything be okay. As mentioned within PR #8 we need a special version of module tornado to run the script as is. #8 Includes this commit additionally, so you could also close this and only merge that one.

SvenRoederer commented 4 years ago

Probably just add the "tornado change" from PR #8 as an additional commit to this "python3 compatibility" PR.

SvenRoederer commented 4 years ago

@sarumpaet according to PEP469 this change of d.iteritems looks fine. Can you review and cherry-pick e0036698f7799f63fc4004bef2798ed05e938435 and deloy on the server? (I already cherry-picked 383fda35bbf0c58b943fd27becccd9ef3a6abdaa)

sarumpaet commented 4 years ago

cherry picked and merged manually.