freifunk-darmstadt / gluon-firmware-selector

Firmware selector for gluon router images
https://firmware.darmstadt.freifunk.net/
GNU Affero General Public License v3.0
22 stars 49 forks source link

Hide Vendor for which no images are available #118

Closed herbetom closed 4 years ago

herbetom commented 4 years ago

In #117 it was achieved that only vendors from the enabled_device_categories are shown in the vendor dropdown. But if a vendor is included in the enabled_device_categories but no firmware for a device from that vendor was generated it is still shown.

You can see this under https://firmware.darmstadt.freifunk.net/ where Linksys⁣ is in the List of vendors, but a firmware for the WRT1200AC (the only Linksys⁣ devices in recommended (the config value for enabled_device_categories)) wasn't generated.

A check if their are actually images available would be neccesary.

herbetom commented 4 years ago

The fix in d45019d10513ce0306c66d7744cbcd8fbe25683c caused problems if for a given vendor their was no device available. I created a PR #122