freifunk-gluon / gluon

a modular framework for creating OpenWrt-based firmwares for wireless mesh nodes
https://gluon.readthedocs.io
Other
545 stars 325 forks source link

New dot release to patch KRACK #1240

Closed J0WI closed 6 years ago

J0WI commented 6 years ago

Please release a new version to patch the KRACK vulnerability. While free/open networks are not affected, the "private wlan" functionality of Gluon is.

Patches have already been merged in the LEDE project and they will soon ship a new stable release.

rotanid commented 6 years ago

they didn't release yet because they aren't finished patching from what i read on their IRC. so i guess gluon is waiting for them being finished

neocturne commented 6 years ago

Please note that most of the KRACK attack variants must be mitigated on the client side. https://w1.fi/security/2017-1/wpa-packet-number-reuse-with-replayed-messages.txt lists only two issues that affect the AP side - one of them requiring 802.11r to be enabled (which is not the case in Gluon's private WLAN config), and the other depending on a supplicant implementation with a specific broken behaviour (the existence of such implementations is speculative).

Hence, the impact of KRACK on the supported Gluon feature set is very low. We will still make a new release very soon, to fix the issues for users with unusual deployments that use nodes as WLAN clients.

rubo77 commented 6 years ago

Couldn't we offer an extra special private WiFi that only forward TLS connections?

Https and starttls only!

flobeier commented 6 years ago

@rubo77, I don't see how that would be beneficial or even necessary. But you can implement that using iptables if you want.

0x4A6F commented 6 years ago

We might consider adding an option to implement this hostapd commit.

J0WI commented 6 years ago

LEDE 17.01.4 has been released: https://lede-project.org/releases/17.01/changelog-17.01.4#security_fixes

neocturne commented 6 years ago

The Gluon v2017.1.x branch now contains the KRACK fixes.

The workaround mentioned by @0x4A6F can be configured using UCI after updating (see https://git.lede-project.org/?p=source.git;a=commitdiff;h=d501786ff25684208d22b7c93ce60c194327c771 ); I don't think we need to provide a graphical knob for the workaround (and enabling it is probably a bad idea, as it will make the WPA handshake less robust in lossy environments, and having a mesh network running on the same channel will definitely cause some interference...).

I'm still waiting for the kmod-jool build fix to be acked upstream (reported on Gluon ML), and plan to start preparing the next Gluon release after that.

rubo77 commented 6 years ago

What do you mean with a graphical knob?

neocturne commented 6 years ago

@rubo77 A switch in the web GUI.

J0WI commented 6 years ago

I'm still waiting for the kmod-jool build fix to be acked upstream (reported on Gluon ML), and plan to start preparing the next Gluon release after that.

Is there an update on this? Do you consider a fix-KRACK only release if other patches are blocked upstream?

rotanid commented 6 years ago

@J0WI that's not an issue anymore, he already prepared the release notes: #1251