search

freifunk-gluon / gluon

a modular framework for creating OpenWrt-based firmwares for wireless mesh nodes
https://gluon.readthedocs.io
Other
553 stars 325 forks source link

linux: net: dsa: mt7530: add support for bridge port isolation #3286

Open neocturne opened 5 months ago

neocturne commented 5 months ago

Adds bridge port isolation to MT7621-based devices like the Ubiquiti EdgeRouter-X.

Part of #2679.

neocturne commented 5 months ago

Updated to the version accepted for net-next and OpenWrt main

rotanid commented 5 months ago

for me, stuff that was accepted in net-next and openwrt main doesnt need a further review by gluon maintainers, it's only a question about whether we want to backport it. i'd say yes.

neocturne commented 5 months ago

I did have to make some changes to the patches for 5.15, but yes, the main question is whether we want the backport.

herbetom commented 4 months ago

Is there a reason to track this backport downstream and not in the OpenWrt repo? Seems like something that's not gluon specific.

Otherwise it seems justifiable to backport it.

neocturne commented 4 months ago

Arguably it's a breaking change, so I'd rather not backport it to OpenWrt stable branches.

herbetom commented 4 months ago

From my understanding bridge port isolation is only enabled if that setting has been enabled and AFAIK it's not by default in openwrt (only gluon enables it by default). Therefore it should only break stuff if a user enabled it in the past, forgot about it and then it suddenly starts working. That doesn't really seem like a problem openwrt should care about.

neocturne commented 4 months ago

The first patch affects all drivers, not just those that actually support the offloading; it also doesn't only affect port isolation, but also other bridge flags. It's difficult to say what the exact effects might be.

rotanid commented 3 months ago

let's test in master, we can revert later if we have issues with this

@neocturne i suggest you try you build and if necessary refresh patch with current master branch and merge it youself

neocturne commented 1 month ago

Status: I want to include the qca8k patches as well (not sure if they have been backported to OpenWrt main already)