search

freifunk-saar / ff-node-monitor

Monitoring for Freifunk nodes
GNU Affero General Public License v3.0
3 stars 2 forks source link

RFC: revert removal of support for manual node ID #54

Closed rubo77 closed 5 years ago

rubo77 commented 5 years ago

(reverted from commit 66bd85ea86571b59b324b4393ddbb34916e2c891)

untested, but we should re-enable this. Maybe we should add a config option to show the mac-address input filed or not?

RalfJung commented 5 years ago

It's not the MAC address, it's the node ID. Gluon happens to usually compute that from one of the many MAC addresses of the device, but I don't think mixing up terminology here is a good idea.

Also, if possible I'd like to avoid having two input boxes. Can you instead turn the drop-down into a freely editable field with auto-completion?

RalfJung commented 5 years ago

Closing due to inactivity. If you find a good way to make this into a single input element, feel free to reopen!

rubo77 commented 5 years ago

please reopen, I plan to do this, when I find the time, (seems not so complicated)

RalfJung commented 5 years ago

Sure, I'll reopen when there is something to review. :) I'd like to keep the pull requests limited to something actionable. Otherwise we'll just end up with a long list of dead PRs.

rubo77 commented 5 years ago

Maybe we can leave this open and just add a tag "planned for later' or so.

Otherwise good ideas get lost in the list of closed issues

RalfJung commented 5 years ago

This is not an issue though, it is a PR.

If you want to file an issue, that's okay for me.