search

freifunk / openwrt-packages

Freifunk specific global OpenWrt Packages
Apache License 2.0
26 stars 33 forks source link

freifunk-policyrouting: do not run init-script in imagebuilder #10

Closed SvenRoederer closed 4 years ago

SvenRoederer commented 5 years ago

This is to follow up https://github.com/openwrt/luci/pull/1635 after splitting freifunk-packages from luci-feed. Original issue-statment below:

When creating final images the build-scripts running the package init-scripts. As of including files like on a real system (line 4, 5), with absolute path, this will fail.

Activating init scripts build_dir/target-mips_24kc_musl/root-ar71xx/etc/init.d/freifunk-policyrouting: line 4: /lib/functions/network.sh: No such file or directory build_dir/target-mips_24kc_musl/root-ar71xx/etc/init.d/freifunk-policyrouting: line 5: /lib/functions.sh: No such file or directory

Running this init-script outside of a real-system don't seem to make sense at all, so just exit gracefully.

SvenRoederer commented 4 years ago

As per https://github.com/openwrt/luci/pull/1635#issuecomment-368266512, https://github.com/openwrt/luci/pull/1635#issuecomment-385257774 the init-scripts are now enabled by default in OpenWrt. As this was probably not done in the very early OpenWrt releases, out postinst was added to the package. When OpenWrt changed to activate the init-scripts by default, this was very likely the moment when this error came up.

there is also an Issue in the Freifunk-Berlin project relating to this: https://github.com/freifunk-berlin/firmware/issues/423#issuecomment-280925135

SvenRoederer commented 4 years ago

fixed by https://github.com/freifunk/openwrt-packages/commit/5425bc9daa0cf18a9aff6e77c3b35c677e04f538