search

freifunk / openwrt-packages

Freifunk specific global OpenWrt Packages
Apache License 2.0
26 stars 33 forks source link

freifunk-common: make olsr status available again for unauthed users #31

Closed XDjackieXD closed 3 years ago

XDjackieXD commented 4 years ago

Due to addition of acl-dependencies in luci, the olsr status page was not accessible by users that were not logged in. This patch fixes this. I hope this is the right way to do it as I'm not that deep into the luci codebase and the documentation is not that great...

SvenRoederer commented 4 years ago

I assume you got this error woth LuCI master? What was the exact error look like?

XDjackieXD commented 4 years ago

With current luci master the olsr status page just won't load (403 with completely empty body) when accessed via the funkfeuer status page (olsr status on the admin page works fine). After a bit of digging I found out that it fails here https://github.com/openwrt/luci/blob/master/modules/luci-base/luasrc/dispatcher.lua#L913 and after a bit more digging the solution in this PR seemed like the correct solution

SvenRoederer commented 3 years ago

made a working setup on my side and can confirm that it make the page show up again. But I'm not sure what this function is doing behind the scenes ...

SvenRoederer commented 3 years ago

As nobody seems to veto I'm in favour of merging this.

SvenRoederer commented 3 years ago

merged in d88313c and afd5335cbd0e for openwrt-21.02