freifunkMUC / site-ffm

Freifunk München specific Gluon configuration
16 stars 35 forks source link

Mesh-VPN cannot be disabled in config mode #136

Closed goligo closed 2 years ago

goligo commented 3 years ago

Due to the custom config mode plugin we used for wireguard in the past, there are nodes with a configuration mismatch, where

gluon.mesh_vpn.enabled=0

and

wireguard.mesh_vpn.enabled=1

To address this issue the update script for wireguards currently sets gluon.mesh_vpn.enabled, in case wireguard.mesh_vpn.enabled is 1. This is causing an issue in the config UI - it is currently not possible to disable Mesh-VPN.

In theory all nodes should now be consistent again, as the firmware update containing the migration script has been rolled out, and it can be removed with the next release. In practice there are some routers that still show the mismatch (NanoPi R2S) for reasons yet to be analyzed, and would disable Mesh-VPN (thus causing nodes to get offline), if the script is removed.

https://github.com/freifunkMUC/community-packages/blob/995c77ec03dc54942abb1bca7870fb9d458a7387/gluon-mesh-vpn-wireguard-vxlan/luasrc/lib/gluon/upgrade/400-mesh-vpn-wireguard#L22

goligo commented 2 years ago

Issue with NanoPi R2S and autoupdater has been fixed. So as soon this has been rolled out once to NanoPis, we can finally remove this line. https://github.com/freifunk-gluon/gluon/issues/2318

goligo commented 2 years ago

Fixed with https://github.com/freifunkMUC/community-packages/commit/92f356e7eee92cb1ca326db4aed7983e6b91e568 , can be closed after next release, where the change is included.