search

freifunkh / ansible

Here we store all Ansible roles and configs used for Freifunk Hannover.
MIT License
7 stars 3 forks source link

all: Add new role ffh.restic. #176

Closed lemoer closed 3 years ago

lemoer commented 3 years ago

As the backup machine will be set up by @1977er tomorrow, this will not roll successfully yet. Therefore I put this into a PR. If he's done, he can take this and roll it. See comments below...

For most of the nodes, this only backups /etc/. Some nodes specify the restic_backup_paths variable in their host_vars and backup additional paths.

Currently this is not rolled out yet, as @1997er has to create the backup machine first. However, once he is finished, he can adjust the remaining variables (marked with "TODO") in group_vars/all/backups.yml. Then he can roll all playbooks with "-t restic" and things should work out smoothly. Let's see...

Some discussion about this can be found in #118.

AiyionPrime commented 3 years ago

On 28af7b9e1ba38bd801777d8d0223d599c5fe30c4 This linting-on-foreign-rules-thing really annoys me more than it should. I don't think it makes the role more readable if every usual string like names of tasks is wrapped again in quotes. Like, yml wants to be readable, so why add more boilerplate, when it's not necessary for the human, nor the machine?

The delegate to localhost changes are unintuitive imo. Does local_action not allow multiline task descriptions?

AiyionPrime commented 3 years ago

How does restic behave, when the path it's supposed to backup does not exist, yet?

lemoer commented 3 years ago

The delegate to localhost changes are unintuitive imo. Does local_action not allow multiline task descriptions?

@1977er mentioned, that local_action will be deprecated at some point in future.

How does restic behave, when the path it's supposed to backup does not exist, yet?

Good point. We should check the behavior in that case.