search

freight-team / freight

A modern take on the Debian archive.
Other
107 stars 37 forks source link

Minor suggestion from shellcheck linting of freight-cache #43

Closed brother closed 7 years ago

brother commented 8 years ago

https://github.com/freight-team/freight/blob/master/bin/freight-cache#L70 reads

[ -z "$GPG_PASSPHRASE_FILE" -o -r "$GPG_PASSPHRASE_FILE" ] || echo "# [freight] could not read passphrase file: $GPG_PASSPHRASE_FILE." >&2

This is reported as ambigious and should be changed to use the form [ something ] || [ something ] for better consistency. Like so:

[ -z "$GPG_PASSPHRASE_FILE" ] || [ -r "$GPG_PASSPHRASE_FILE" ] || echo "# [freight] could not read passphrase file: $GPG_PASSPHRASE_FILE." >&2

Thank you.