search

freiheit-com / kuberpult

Kuberpult helps you manage different versions of different microservices in different cluster.
MIT License
38 stars 11 forks source link

Error spam when Rollout Service disabled #1906

Open bernardo-bastos opened 2 months ago

bernardo-bastos commented 2 months ago

Hello Kuberpult Team,

Currently our kuberpult instance is not using the rollout service. We observed that our Datadog instance is accumulating several errors rpc error: code = Unimplemented desc = rollout service not configured.

After some investigation we believe that a check on StreamStatus() method is causing this error every time the UI is accessed and the rollout service disabled. Here are some links: Due to this call: https://github.com/freiheit-com/kuberpult/blob/main/services/frontend-service/src/ui/App/index.tsx#L109 And this line: https://github.com/freiheit-com/kuberpult/blob/main/services/frontend-service/pkg/cmd/server.go#L701

Is this the expected behaviour?

hannesg commented 2 months ago

Hi @bernardo-bastos,

I did this mainly for easier backward compatibility. We have the rollout service enabled in most projects as it provides valuable features. However, I would be fine with handling this case without the error code.