search

freiksenet / react-calendar

A modular toolkit to build calendar-related things in React
http://freiksenet.github.io/react-calendar/
MIT License
249 stars 46 forks source link

Upgrade react #19

Closed ericwooley closed 9 years ago

ericwooley commented 9 years ago

I got rid of references to withComponent, and everything seems to work. There are no unit tests or anything, so it's hard to say for certain.

I also noticed you are relying on mixins pretty heavily and you may want to consider composition instead because mixins appear to be on their way out. https://medium.com/@dan_abramov/mixins-are-dead-long-live-higher-order-components-94a0d2f9e750

freiksenet commented 9 years ago

You don't need to add dist/ to the folder, it's autobuilt when npm publish is run.

It looks fine otherwise, I'll merge after you remove the dist. I am aware of the mixin problem - I plan to refactor it anyway, the current state is what I thought would work nice at that moment, but turned out that this way of writing the code is not the best.

Fixes #18.

ericwooley commented 9 years ago

Sorry, I meant to do that on a different branch so it wouldn't affect the PR, but I moved them back.