Remove state in order to allow for paging

freiksenet / react-calendar

A modular toolkit to build calendar-related things in React

http://freiksenet.github.io/react-calendar/

MIT License

249 stars 46 forks source link

Remove state in order to allow for paging #2

Closed parris closed 9 years ago

parris commented 9 years ago

Changing wouldn't work since the state never got updated. This change entirely relies on props.

Testing

Created a simple month paging example and tried to page months
TODO: test with other calendar configurations

freiksenet commented 9 years ago

Thanks!

The idea was to have Calendar as a stateful component with pager, but I never got to actual implementation of state management, so I think it's a good idea to make it pure and provide a stateful component as a wrapper later.

I'll merge after you fix the small issue with cloning moment twice.

parris commented 9 years ago

Done! I do have an example of a pager if that'd be helpful.

freiksenet commented 9 years ago

If you can contribute a component that does paging, it would be very nice. Even an example for the README would be very nice, feel free to do pull requests for both.