freitdav / BDRthermostatHA

BDR (Baxi, De Dietrich, Remeha) thermostat custom component integration for Home Assistant
GNU General Public License v3.0
48 stars 21 forks source link

Draft: feat: make brand configurable #2

Closed mmoerdijk closed 2 years ago

mmoerdijk commented 2 years ago

Hi,

Thanks for your work on this integration.

I have a remeha thermostat and was able to use this integration after modifying it a bit by changing baxi to remeha.

I decided to make the brand configurable and add it to the initial configuration screen. For now I only added baxi and remeha. I also fixed a small bug that was causing the state to be set incorrectly after changing it resulting in an error in lovelance.

There is still a bug in there that makes it in possible to set the mode to "frost" or "holiday" but i rather fix that in a separate MR ( If I get around fixing that)

Are you accepting PR's like this?

mmoerdijk commented 2 years ago

Please not that I marked it as Draft because I'm not able to test this with a baxi thermostat, so it would be great if someone could help me with that.

freitdav commented 2 years ago

Hi Mart, thank you for your contribution. I found no issues in the code, thus approving the merge. I do not currently have time to develop more features or refactor the code, but any ideas are welcome for the future.

mmoerdijk commented 2 years ago

Hi Freitdav,

Thank you for the review. You approved the merge but did not merge it but closed it :thinking:

Was that an mistake?

freitdav commented 2 years ago

Yup, sorry, missclicked. It should be fine now. Thank you for your work and greetings from the Czech Republic.

KaijserDjerzy commented 1 year ago

Hey guys, im fairly new to the whole writing your own code thing. I have the intergration installed but i cant seem to work out how to actually configue my thermostat to it.

Can u help?

mmoerdijk commented 1 year ago

Goto settings > devices and Services and press the big add Integration Button.

Search for BDR and it should pop up

jkottier commented 1 year ago

This pull request works like a charm with my Remeha Calenta 40c:

Steps I've done to get this working in my HA (version 2022.9.7 / OS 8.3 / HACS 1.26.0)

  1. Go to HACS > Integrations and add a custom repository "https://github.com/freitdav/BDRthermostatHA/pull/2" via the 3 dos (...) on the top right, after this you'll need to restart HA.
  2. Get a pairing code from either the eTwist thermostat or app 2a. from your eTwist thermostat (Settings > Register device or service) 2b. from your eTwist app (Settings > Connected devices and services > Invite someone)
  3. add BDR integration via HA menu (Settings > Integrations > Add integration > BDR Thermostat
  4. fill in the credentials for your eTwist account (email/password), pairing code and choose for the "remeha" radiobutton
mmoerdijk commented 1 year ago

This pull request works like a charm with my Remeha Calenta 40c:

Steps I've done to get this working in my HA (version 2022.9.7 / OS 8.3 / HACS 1.26.0)

  1. Go to HACS > Integrations and add a custom repository "https://github.com/freitdav/BDRthermostatHA/pull/2" via the 3 dos (...) on the top right, after this you'll need to restart HA.
  2. Get a pairing code from either the eTwist thermostat or app 2a. from your eTwist thermostat (Settings > Register device or service) 2b. from your eTwist app (Settings > Connected devices and services > Invite someone)
  3. add BDR integration via HA menu (Settings > Integrations > Add integration > BDR Thermostat
  4. fill in the credentials for your eTwist account (email/password), pairing code and choose for the "remeha" radiobutton

Should be in the main repo now, so please use that.

robhuls commented 1 year ago

Works with my Remeha Avanta with eTwist, thanks!

HanSyt commented 1 year ago

Hi,

I used this integration and it worked fine with Home Assistant. However Remeha has moved me to the Remeha App (was Etwist). It seems that Remeha has moved an incomplete app into production, according to the faq several possibilities are not working yet. Sadly the BDR integration is not working anymore since I was forced to move, is there anyone with a solution already.

Forget this, I had to move to another plugin - see the issues page