frej / fast-export

A mercurial to git converter using git-fast-import
http://repo.or.cz/w/fast-export.git
808 stars 255 forks source link

Issue: Missing space before < in ident string: User Name<username> #264

Closed luislobo closed 3 years ago

luislobo commented 3 years ago

fatal: Missing space before < in ident string: User Name<username> <devnull@localhost> 1317750581 -0300

luislobo commented 3 years ago

The command issued includes --force as I had unnamed heads

frej commented 3 years ago

Use an author map (-A) or a plugin to correct it.

luislobo commented 3 years ago

I actually found the problem and fixed it.

Replacing: user_re=re.compile(b'([^<]+) (<[^>]*>)$') with user_re=re.compile(b'([^<]+)\s*(<[^>]*>)$') in hg2git.py

Basically, making the spaces between the name and the <> optional

luislobo commented 3 years ago

If you want I can create a PR for this.

frej commented 3 years ago

If you want I can create a PR for this.

Fast-export tries to not inflict arbitrary naming policy on the user, instead it aims to provide mechanisms allowing the user to apply their own policy. The way to do fixups is with author maps or plugins.

luislobo commented 3 years ago

OK, thanks.

How would then be this particular use case be fixed then? the user is:

User Name<username> (note, no space in between the name and what should have been an email).

Does the existance of authors.map with the following content sufice?:

"User Name<username>"="User Name <username>"

frej commented 3 years ago

Does the existance of authors.map with the following content sufice?:

"User Name<username>"="User Name <username>"

That should be sufficient.

thedebtkiller commented 3 years ago

business payees customers create an account and consumers payers create an account adding the company that they owe and account number to pay companies pay 5% of the payment to us that they receive and consumers pay a monthly feed of $5 for using the app stores sales the on the go cards for $3 and pay 2% to us for adding the as collators

frej commented 3 years ago

No activity in more than 90 days, closing.