frej / fast-export

A mercurial to git converter using git-fast-import
http://repo.or.cz/w/fast-export.git
808 stars 255 forks source link

Adding doc updates #268

Closed admiralAwkbar closed 3 years ago

admiralAwkbar commented 3 years ago

@frej love the work you have on this. Was using it and wanted to help contribute back!

Will eventually add back to the bash and python code once tested a bit more :)

The Dockerfile was a nice way to help users distribute this and have a repeatable env

admiralAwkbar commented 3 years ago

@frej Hey thanks for the feedback.

Yeah if your not keen on Docker then I would say to remove it. It was helpful to get an exporter instance up and running with the code base and helps users have a repeatable env that you can test, develop, and repeat.

I forgot I had the Super-Linter for my local testing and it was a big push. Its a great tool to help solve coding practices, and ill remove as that shouldn't have came with my push.

The coding brackets should have been text and will update

frej commented 3 years ago

Making a stone statue out of a block of stone is simple, you just chisel away all material which does not belong to the finished statue. Although this is admired in stonemasonry, it is not the way to make a software maintainer happy :)

Please make sure your pull-request follows the advice given in the "Submitting Patches" section in the README. Apart from being very hard to review in its current state, there is no point in maintaining the PR revision history.

admiralAwkbar commented 3 years ago

@frej its fine ill close this