Add forward slash to the list of characters to sanitize in sanitize_name

frej / fast-export

A mercurial to git converter using git-fast-import

http://repo.or.cz/w/fast-export.git

808 stars 255 forks source link

Add forward slash to the list of characters to sanitize in sanitize_name #285

Closed danielpunkass closed 2 years ago

danielpunkass commented 2 years ago

See Issue #32, I believe this is the correct fix for the underlying issue causing that import failure, or at least it addresses one of the possible branch naming problems that could lead to the issue.

frej commented 2 years ago

Please read the comment block starting the function your are modifying. It both contains an explanation for why your patch is the wrong solution and what the right solution to the problem which triggered your PR is. Besides that, / is perfectly valid in Git branch names, so there is no reason to sanitize it. Read the first item in the "Frequent Problems" section of the README for a crash course on Git branch naming.

danielpunkass commented 2 years ago

Oh! I'm embarrassed to have glossed right over that comment in the sources. Thanks for explaining so patiently.

paulwratt commented 2 years ago

"live and learn"