reads and writes mistakenly allows paths inside the group_for_references to be used

frejanordsiek / hdf5storage

Python package to read and write a wide range of Python types to/from HDF5 formatted files. Can read/write data to the HDF5 based Matlab v7.3 MAT files.

BSD 2-Clause "Simplified" License

83 stars 24 forks source link

reads and writes mistakenly allows paths inside the group_for_references to be used #88

Closed frejanordsiek closed 4 years ago

frejanordsiek commented 4 years ago

The reads, writes, read, and write functions currently allow objects inside the Group used for references to be read from or written to directly. This is a risky thing to do and was definitely not intended, and is a bug.

frejanordsiek commented 4 years ago

Fixed in the master branch in commit 1a14bd852e44c143e5fd96f9825c4028f88f0fd7. I will not fix it in the 0.1.x branch. It is a minor bug in some ways and fixing it does break API compatibility (not sure if anyone was using it, though), so the bug will be preserved in the 0.1.x branch.