search

frekw / kirby-modules

A simple module system for http://getkirby.com
MIT License
23 stars 3 forks source link

module init + checkbox problem #13

Closed dirkschmid closed 8 years ago

dirkschmid commented 8 years ago

Hi,

  1. after the last update i could not use the the modules anymore, cause you changed the initialization, it was this: <?php echo $page->modules()->modules() ?> what changed?
  2. and i discovered a problem with options, if i set a checkbox. it only get's rendered if its checked, so i get an error if it's unchecked, in the template cause its not there.

Any help?

frekw commented 8 years ago

Hey!

Nothing should have changed in terms of how the modules are rendered, <?php echo $page->modules()->modules() ?> is still be the way to do it.

In regards to the checkboxes I use them in multiple places without any issues. In order to reproduce this I need more info, preferably with examples.

But due to time constraints I can't make any promises that I'll have time to dig into the underlying issue for quite some time.

bugsysop commented 8 years ago

Same problem with last update, module did'nt render anymore on public site... No visible problem in the panel view.

frekw commented 8 years ago

I need more info to reproduce this since I'm not seeing it. Can you please provide a repo with a minimal test case?

bugsysop commented 8 years ago

It's just a quick and dirty try on MAMP.

First I tested with your Modules Exemple here. It whas working like a charm... apart from missing .htaccess file

Then I updated manualy the plugin an field... and now it work on backend but render nothing on front.

The rendered HTML from my page is exactly:

<!DOCTYPE html>
<html lang="en">
<head>

  <meta charset="utf-8" />
  <meta name="viewport" content="width=device-width,initial-scale=1.0">

  <title>Kirby Starterkit | Home</title>
  <meta name="description" content="This is Kirby's Starterkit.">
  <meta name="keywords" content="Kirby, CMS, file-based">

  <link rel="stylesheet" href="http://localhost/kirby-modules/assets/css/main.css">  <link rel="stylesheet" href="http://localhost/kirby-modules/modules.css">  <script src="http://localhost/kirby-modules/modules.js"></script>
</head>
<body>

  <header class="header cf" role="banner">
    <a class="logo" href="http://localhost/kirby-modules">
      <img src="http://localhost/kirby-modules/assets/images/logo.svg" alt="Kirby Starterkit" />
    </a>
    <nav role="navigation">

  <ul class="menu cf">
      </ul>

</nav>
  </header>
  <main class="main" role="main">
    <h1>Home</h1>
    <p>Some body content.</p>    <div class="hero hero--align-

No modules, no footer, brutaly cut at <div class="hero hero--align-

bugsysop commented 8 years ago

Just tried with a fresh install of Starter Kit, exact same result !

I installed 2 fields (selector & modules) and one plugin (modules) I inserted the necessary code in header & config files, and used the blueprint from your test package.

Configuration : MAMP 3.5 - PHP 5.6.10

frekw commented 8 years ago

Please provide the code if you want me to look at it.

Thanks!

On Tue, Jun 21, 2016, 07:20 Aris notifications@github.com wrote:

Just tried with a fresh install of Starter Kit, exact same result !

I installed 2 fields (selector & modules) and one plugin (modules) I inserted the necessary code in header & config files, and used the blueprint from your test package.

Configuration : MAMP 3.5 - PHP 5.6.10

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/frekw/kirby-modules/issues/13#issuecomment-227343193, or mute the thread https://github.com/notifications/unsubscribe/AACqb07x3O7XDNR7zSkrkfTdCBTNk-RVks5qN3SygaJpZM4I4lrN .

dirkschmid commented 8 years ago

check out here: https://github.com/dirkschmid/kib-mod-test

its the latest kirby with your latest plugin.

bugsysop commented 8 years ago

And this is mine. https://github.com/bugsysop/kirby-modules-test

frekw commented 8 years ago

The example repo haven't been updated in a while. All module fields are now regular kirby fields, such calls like $module->options->style->value() should be $module->options()->style()->value() to work properly. I haven't gotten around to updating the example after that change. Just change all modules templates and it should be fine.

dirkschmid commented 8 years ago

works, thank you!

bugsysop commented 8 years ago

Works for me to... but not for nested modules.

All module (hero, text, button) works directly inserted in the page. Text and button modules, not showing when inserted (nested) in hero.

I think the problem come from this portion of code in the hero template:

<?php if(isset($module->content)): ?>
    <?php echo $module->content->modules() ?>
<?php endif; ?>

I modified to this (with no result):

<?php if(isset($module->content)): ?>
    <?php echo $module->content()->modules() ?>
 <?php endif; ?>

Thanks @frekw for your help and sweet plugin/field

frekw commented 8 years ago

Try if($module->content()->isNotEmpty()):

-- F

On Tue, Jun 21, 2016, 19:53 Aris notifications@github.com wrote:

Works for me to... but not for nested modules.

All module (hero, text, button) works directly inserted in the page. Text and button modules, not showing when inserted (nested) in hero.

I think the problem come from this portion of code in the hero template:

<?php if(isset($module->content)): ?> <?php echo $module->content->modules() ?> <?php endif; ?>

I modified to this (with no result):

<?php if(isset($module->content)): ?> <?php echo $module->content()->modules() ?> <?php endif; ?>

Thanks @frekw https://github.com/frekw for your help and sweet plugin/field

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/frekw/kirby-modules/issues/13#issuecomment-227519244, or mute the thread https://github.com/notifications/unsubscribe/AACqb609JzfCgOcZeOM57OPvIrWsiTqGks5qOCUmgaJpZM4I4lrN .

bugsysop commented 8 years ago

No effect !

frekw commented 8 years ago

<?= $module->module_field_name()->modules() ?> 100% works.

On Tue, Jun 21, 2016, 20:10 Aris notifications@github.com wrote:

No effect !

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/frekw/kirby-modules/issues/13#issuecomment-227524153, or mute the thread https://github.com/notifications/unsubscribe/AACqb10cW5vGipymtXp_pliL6ABnUHNlks5qOCkVgaJpZM4I4lrN .

bugsysop commented 8 years ago

Not for me :-(

Tried this:

<?php if($module->content()->isNotEmpty()): ?>
    <?php echo $module->module_field_name()->modules() ?>
 <?php endif; ?>

And this:

<?php if(isset($module->content)): ?>
     <?php echo $module->module_field_name()->modules() ?>
<?php endif; ?>

None worked

Juste commited my code on GH

frekw commented 8 years ago

That was just an example. The real code would be:

<?php if($module->content()->isNotEmpty())): ?>
     <?php echo $module->content()->modules() ?>
<?php endif; ?>

or just

<?php echo $module->content()->modules() ?>

Hope that helps.

I'm sorry to say, but this is a bug tracker – not a support forum. If you have programming related questions please refer to StackOverflow or Kirby's support forum

bugsysop commented 8 years ago

Sorry.