search

fremail / sequelize-nested-set

Library to store and manage nested set trees using Sequelize
MIT License
39 stars 10 forks source link

Wrong delete where params #14

Closed aslubsky closed 4 years ago

aslubsky commented 4 years ago

Look like you have a bug in delete method here https://github.com/fremail/sequelize-nested-set/blob/master/index.js#L888 1) using await this.destroy(dOptions); insted of await Model.destroy(dOptions); now generate sql DELETE FROMtableNameWHEREid= 123 2) using dOptions.where.lft in same where params will generate sql only for last param, like DELETE FROMtableNameWHERElft<= 10 ANDtree_key= 1 I've prepared PR, pls check

fremail commented 4 years ago

Thank you @aslubsky for reporting the issue and fixing it!

I merged your PR and released v.1.4.0 so your fix is already published 🎉