search

freman / hass-nopwned

A dirty little addon to patch haveibeenpwned out of supervisor
MIT License
5 stars 0 forks source link

Doesn't work with supervisor-2021.03.6 #2

Open rlowens opened 3 years ago

rlowens commented 3 years ago

Updated to supervisor-2021.03.6 and it seems like this isn't working now?

freman commented 3 years ago

I noticed it had returned.

What's more interesting is I didn't update superviser.

freman commented 3 years ago

Testing a solution

freman commented 3 years ago

Good news, this addon is now longer required

https://community.home-assistant.io/t/opt-out-of-pwned-secrets-warnings/286394/241

To anyone interested, the password check can now be disabled with the command below in the CLI using the latest versions of either the core-ssh add-on or the community ssh add-on:

Terminal & SSH (core) version 9.1.0 SSH & Web Terminal (community) version 8.0.4

ha resolution check options --enabled=false addon_pwned

alesoft73 commented 3 years ago

With Supervisor 2021.03.6 notifications keep coming.... :-( The command insert with CLI don't work ...

freman commented 3 years ago

What version of terminal & ssh do you have?

ForumHulp commented 3 years ago

Same here, terminal 9.1.0 Command completed succesfully but problem stays, also after restart supervisor

freman commented 3 years ago

Interesting, their fix worked for me.

I have a patch sitting there I just haven't tested it.

alesoft73 commented 3 years ago

To day work. I don't know why.....

"21-03-18 12:21:45 WARNING (MainThread) [supervisor.resolution.check] Skipping disabled check addon_pwned"

I have use SSH & Web Terminal ver. 8.0.4 and Portainer for send the command.

I suppose that once the command is sent you have to do the complete reboot.

freman commented 3 years ago 

21-03-18 14:02:14 INFO (MainThread) [supervisor.resolution.check] Starting system checks with state CoreState.RUNNING
21-03-18 14:02:14 INFO (MainThread) [supervisor.resolution.checks.base] Run check for IssueType.FREE_SPACE/ContextType.SYSTEM
21-03-18 14:02:14 WARNING (MainThread) [supervisor.resolution.check] Skipping disabled check addon_pwned
21-03-18 14:02:14 INFO (MainThread) [supervisor.resolution.checks.base] Run check for IssueType.SECURITY/ContextType.CORE
21-03-18 14:02:14 INFO (MainThread) [supervisor.resolution.check] System checks complete
21-03-18 14:02:14 INFO (MainThread) [supervisor.resolution.fixup] Starting system autofix at state CoreState.RUNNING

definitely disabled for me

If ya'll need it I can test and release the patch but I suspect maybe a reboot?

Sing out if you need the patch.