search

freme-project / e-Entity

Apache License 2.0
1 stars 1 forks source link

language required? #32

Closed pheyvaer closed 8 years ago

pheyvaer commented 8 years ago

Is the language parameter required for /e-entity/dbpedia-spotlight/documents? I've tested it without and it works. However, the documentation does not state that it is optional.

m1ci commented 8 years ago

good catch, for dbpedia-spotlight it is optional, for freme-ner it is not optional. Do you think its better to specify at the e-entity level whether the language parameter is optional or not? or its fine as it is now - at ner engine level?

pheyvaer commented 8 years ago

Well, for a new user who just checks /e-entity/dbpedia-spotlight/documents it would be useful if all information would be present so he doesn't need to read the other documentation.

m1ci commented 8 years ago

makes sense, so we will document the language parameter at NER engine level.

m1ci commented 8 years ago

we can close this issue, a request for updating the documentation was submitted via https://github.com/freme-project/Documentation/issues/47