search

freme-project / e-services

Apache License 2.0
1 stars 1 forks source link

[e-link] throws BadRequest randomly #22

Closed ArneBinder closed 8 years ago

ArneBinder commented 8 years ago

moved from https://github.com/freme-project/e-services/issues/15#issuecomment-229026166

It seems to be HttpException: 502. I think we should return sth more meaningful than BadRequestException("It seems your SPARQL template is not correctly defined.").

Furthermore we should examine when this happens and what causes the 502.

ArneBinder commented 8 years ago

@m1ci any ideas what could cause the 502?

m1ci commented 8 years ago

It seems to be caused by one of these lines:

https://github.com/freme-project/e-services/blob/master/e-link/src/main/java/eu/freme/eservices/elink/api/DataEnricher.java#L80

https://github.com/freme-project/e-services/blob/master/e-link/src/main/java/eu/freme/eservices/elink/api/DataEnricher.java#L180

ArneBinder commented 8 years ago

I can not reproduce this anymore but will change the error message when I'm back in office.

jnehring commented 8 years ago

When the external API returns 502, then FREME should return 502 also. Together with an error message "The remote triple store could not be reached.". @ArneBinder please implement

ArneBinder commented 8 years ago

Implemented.