freme-project / freme-ner

Apache License 2.0
6 stars 1 forks source link

implement mode parameter #23

Closed m1ci closed 9 years ago

m1ci commented 9 years ago

Implement mode parameter which will enable to do just spotting or spotting+linking E.g., mode=spotting,linking

jnehring commented 9 years ago

See some more task description here: https://github.com/freme-project/technical-discussion/issues/48

nilesh-c commented 9 years ago

This is implemented now. Reflects in live too.

The following options are possible

mode=spot mode=spot,classify mode=spot,link mode=spot,link,classify mode=all (default and same as above) mode=link (Expects NIF data with entity mentions, i.e. anchorOf, beginIndex, endIndex etc. are given and it does only entity linking. This is useful for doing GERBIL entity linking benchmarks)

Note: Order of modes is irrelevant. spot,link,classify is same as spot,classify,link

Please let's test this.

m1ci commented 9 years ago

the parameter needs to be implemented also in e-Entity so it is still not available via e-Entity but only in FREME NER.

jnehring commented 9 years ago

Do you expect a performance difference between spot and spot,classify? Or is it basically the same operation and only influences the output?

nilesh-c commented 9 years ago

It's really the same thing as regards performance/operations performed. Only when link comes into the picture you have a stage of queries to SOLR.

m1ci commented 9 years ago

the mode param has been also implemented in e-Entity. Please check and close. http://api-dev.freme-project.eu/current/e-entity/freme-ner/documents/?informat=text&input=Diego+Maradona+is+from+Argentina.&outformat=turtle&language=de&dataset=dbpedia&mode=spot,link

jnehring commented 9 years ago

I tested it and it works fine. Please provide doumentation: https://github.com/freme-project/Documentation/issues/84