search

freme-project / freme-project.github.io

Apache License 2.0
2 stars 0 forks source link

[live docu] external url fails #309

Closed ArneBinder closed 8 years ago

ArneBinder commented 8 years ago

At any doc page of https://freme-project.github.io/, the menu link FREME Showroom -> FREME Workflow Editor fails.

The variable pages_url defined here is unnecessary and causes errors in live version like the one mentioned because of this line. If the variable will be simply removed, it should work.

Furthermore, the live doc points to the dev version of the freme workflow editor. If this is uninted, it can be changed by modifying the value externurl in this file to {{site.apiProtocol}}://{{site.apiHost}}/freme-workflow-editor/, for instance (or just hardcode it to https://api.freme-project.eu/freme-workflow-editor/).

jnehring commented 8 years ago

The fix @ArneBinder did not work. It led to a page like this:

image

I added a javascript snipped on an empty page that redirects to the external url. I found this tip in a forum. Other solutions include plugins so this was the easiest solution.

ArneBinder commented 8 years ago

@jnehring did you remove all usages of the variable when you deleted it, like this one? Otherwise, the page can not be parsed completely and just the half header will be shown because the Javascript fails. By doing so, no special forwarding should be necessary, it works like intended from Jonathan with the jekyll variable externurl.

jnehring commented 8 years ago

i think we can leave it like it is. thank you @ArneBinder