fix: navTabs uses aria-selected to find active tab

fremtind / jokul

Jøkul er et designsystem utviklet av Fremtind.

https://jokul.fremtind.no

MIT License

63 stars 35 forks source link

fix: navTabs uses aria-selected to find active tab #3865

Closed ivarni closed 4 months ago

ivarni commented 4 months ago

Previously the NavTabs component only considered location.path which does not work with hash URLs

BREAKING CHANGE: If you are not providing aria-selected to the active tab, either because you silenced the TS warning or are not using TS the active component will no longer have an underline

ISSUES CLOSED: #3863

🎯 Sjekkliste

[x] Testet responsivitet og UU (tastaturnavigasjon, skjermleser)
[x] pnpm build og pnpm ci:test gir ingen feil

fremtind-bot commented 4 months ago

Forhåndsvisning: https://jokul.fremtind.no/preview/3863-navtabs-underline/ Commit: 0bad33a501e1e009b828e9d45f391f1d40ec7d03

Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes.