chore: migrate to @chainsafe/is-ip

frenchbread / private-ip

Check if IP address is private.

MIT License

33 stars 16 forks source link

chore: migrate to @chainsafe/is-ip #21

Closed twoeths closed 1 year ago

twoeths commented 1 year ago

Motivation

~is-ip 4.0.0 is the last performant version of is-ip (version 5.0.0 has a performance issue)~
use @chainsafe/is-ip which is significantly faster

Description ~Migrate to is-ip 4.0.0~ Migrate to @chainsafe/is-ip

wemeetagain commented 1 year ago

@tuyennhv can you use @chainsafe/is-ip v2.0.1?

twoeths commented 1 year ago

migrated to @chainsafe/is-ip as it's significantly faster, see https://github.com/ChainSafe/is-ip/pull/1

frenchbread commented 1 year ago

Thanks @tuyennhv & @wemeetagain a lot for the contribution!

@chainsafe/is-ip appears to be an ESM module which private-ip does not support at this point. Would you mind converting this package to esm package? (reference pure ESM). Preferably supporting both cjs & esm.

frenchbread commented 1 year ago

Great work, thanks!