search

frenchtoast747 / webgl-obj-loader

A simple OBJ model loader to help facilitate the learning of WebGL.
http://frenchtoast747.github.io/webgl-obj-loader/
MIT License
281 stars 59 forks source link

use regular expressions rather than touching String.prototype #7

Closed nickdesaulniers closed 9 years ago

nickdesaulniers commented 9 years ago

this is probably faster too, since it doesn't create a bunch of new strings, though I don't have any measurements since the example in the development folder doesn't seem complete.

nickdesaulniers commented 9 years ago

Hey, why did you revert this after merging? https://github.com/frenchtoast747/webgl-obj-loader/commit/b05d62709ae83a3fe90bd109cb3648f87c6266d5

frenchtoast747 commented 9 years ago

I couldn't figure out a way to partially merge and I wanted to make sure you got credit for the majority of the work.

nickdesaulniers commented 9 years ago

It's ok that I don't get credit, as long as I make an effort to upstream my changes. ;)