search

frenck / action-addon-linter

🚀 Frenck's GitHub Action for linting Home Assistant Add-ons.
MIT License
9 stars 3 forks source link

Add NET_BIND_SERVICE capability #180

Closed mrueg closed 5 months ago

mrueg commented 5 months ago

If we add this one, probably a lot of addons could drop NET_ADMIN if they need to bind a well-known port.

mrueg commented 5 months ago

I'm not aware of the Home Assistant Supervisor supporting this?

I might be wrong, could you please point me to a resource (or sourcecode) that shows the existence of this flag for add-ons?

Thanks! 👍

../Frenck Thanks for clarifying! I thought the supervisor just passes it through to docker and I wasn't aware that it gets filtered. What would we need to enable this? Is adding it to https://github.com/home-assistant/supervisor/blob/f150a19c0f77ce3f5223ed563420b38128d2307e/supervisor/docker/const.py (and other occurrences where capabilities are passed to docker) enough?

frenck commented 5 months ago

What would we need to enable this?

Get it added upstream :)

I'm going to close this PR on this end, as it turns out to be invalid at this point.

../Frenck